Use async fs methods #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zxdong262
commented
Oct 4, 2023
•
zxdong262
commented
- Tested in electerm, tsz/trz all works,
- fs.open/fs.write/fs.read still use fs namespace function and sync function, but use await, so we can support pure async env like browser, since we need number type fileHandle, others functions use fs/promises.
- Many tests can not pass, not if it is brought by this PR
lonnywong
reviewed
Oct 4, 2023
|
有道理，我修改一下 |
lonnywong
reviewed
Oct 5, 2023
| for (const func of funcs) { | ||
| fs[func + 'Async'] = (...args) => { | ||
| return new Promise((resolve, reject) => { | ||
| fs[func](...args, (err, data) => { |
There was a problem hiding this comment.
当有多个参数时，这里一个 data 参数不够吧？
https://nodejs.org/api/fs.html#fsreadfd-buffer-offset-length-position-callback
There was a problem hiding this comment.
只有read的callback有多个返回，但是没有用到
There was a problem hiding this comment.
多一个参数，就不需要这样一个一个地赋值了：
https://github.com/electerm/electerm/blob/e6c77eb94e865f511c4a6b9903cdbde09540e6ba/src/client/common/pre.js#L116-L118
可以直接返回另一个 buffer 。
There was a problem hiding this comment.
@zxdong262 我提交了一个 commit 在这个分支上 https://github.com/trzsz/trzsz.js/tree/electerm
（ 没有权限直接提交到这个 PR 中来 ）
lonnywong
reviewed
Oct 5, 2023
lonnywong
reviewed
Oct 5, 2023
|
@zxdong262 trzsz.js 发布了 v1.1.2，包含这个 PR #11 。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.