-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ESM version #338
Add ESM version #338
Conversation
Hey, thanks for the PR! This looks good to me. How would this affect imports of other sub-dependencies for non-esm projects? I guess since utils wasn't touched it shouldn't be a big deal. Thanks again! |
It shouldn't impact subdependencies for non-ESM, I didn't change the behavior for those. Do you have some project where we can test if this works? I can make a prerelease version with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a test for .cjs.js require style of use? I don't currently have a project that is using it aside from in the project itself. But running the local development server and requiring from there may help to test it.
@tscanlin
What particular way of loading do you want to test? |
Thanks for the PR!! |
|
Fixes #337