Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract publish task logic from grunt-gh-pages #1

Merged
merged 1 commit into from
May 30, 2014
Merged

Extract publish task logic from grunt-gh-pages #1

merged 1 commit into from
May 30, 2014

Conversation

markdalgleish
Copy link
Collaborator

Hey Tim. Sorry for the massive pull request, I know how annoying these can be :)

This PR is basically porting all the logic from grunt-gh-pages but removing the dependency on grunt, apart from the utils for now. I've begun trying to port the tests across, but that's going to be a bigger job, so I thought I'd better check in first. There's still lots of work that could be done, but I was hoping to get this into a useable state on npm.

I'm using this work right now in an experimental Gulpfile, in which the deploy task looks like this:

gulp.task('deploy', function(done) {
  ghpages.publish({
    base: path.join(__dirname, 'dist'),
    logger: console.log.bind(console)
  }, done);
});

I'm really keen to help push this over the line so I can use it in my projects, so please let me know if there's anything else I can do to get this onto npm.

@tschaub
Copy link
Owner

tschaub commented May 21, 2014

@markdalgleish apologies for the delay in getting back to you on this. It looks great at a glance. I'll try to make some time for a more careful review and then I'll add you as an owner/maintainer.

@markdalgleish
Copy link
Collaborator Author

Great, thank you :)

When you have time, would you be able to help port the tests? I've made a start but it's proving to be quite difficult due to my unfamiliarity with how the original tests hang together. If you port the first one, I'm more than happy to port the rest.

tschaub added a commit that referenced this pull request May 30, 2014
Extract publish task logic from grunt-gh-pages.
@tschaub tschaub merged commit d678d52 into tschaub:master May 30, 2014
@tschaub
Copy link
Owner

tschaub commented May 30, 2014

Thanks for the effort on this @markdalgleish! I really appreciate your help in making this more generally useful. I've added you as an owner/maintainer of the package. I put up a few obvious issues. Let's keep adding more and publish releases as needed.

tschaub pushed a commit that referenced this pull request May 7, 2021
Add GitHub Action tip for both named and unnamed commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants