Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support --repo CLI option #23

Merged
merged 1 commit into from
Dec 2, 2015
Merged

support --repo CLI option #23

merged 1 commit into from
Dec 2, 2015

Conversation

cvan
Copy link
Contributor

@cvan cvan commented Sep 23, 2015

No description provided.

@@ -10,12 +10,16 @@ program
'base directory for all source files')
.option('-s, --src <src>',
'pattern used to select which files should be published', '**/*')
.option('-r, --repo <repo>',
'URL of the repository you\'ll be pushing to',
'URL of the `origin` remote of the current directory')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need a third arg here otherwise it will be used as a default value if --repo is not specified

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, don't know how that happened

@benoitvallon
Copy link

👍 having this new arg would allow us to do this like:

gh-pages --repo https://$GH_TOKEN@github.com/user/private-repo.git -d dist

@benoitvallon benoitvallon mentioned this pull request Nov 12, 2015
@vvo
Copy link

vvo commented Nov 26, 2015

cc @tschaub can we get this merged and bumped you think?

@cvan
Copy link
Contributor Author

cvan commented Dec 2, 2015

updated; good to go now?

@tschaub
Copy link
Owner

tschaub commented Dec 2, 2015

Thanks for the contribution @cvan!

tschaub added a commit that referenced this pull request Dec 2, 2015
Support `--repo` CLI option.
@tschaub tschaub merged commit 08e470c into tschaub:master Dec 2, 2015
@tschaub
Copy link
Owner

tschaub commented Dec 2, 2015

Published as gh-pages@0.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants