Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CLI exit with error if publishing fails #35

Merged
merged 1 commit into from
Dec 7, 2015
Merged

Make CLI exit with error if publishing fails #35

merged 1 commit into from
Dec 7, 2015

Conversation

timaschew
Copy link
Contributor

always handle error argument in a callback

@timaschew
fix tschaub#20 and comments of tschaub#22
e7d1e31 
always handle error argument in a callback
@timaschew
Copy link
Contributor Author

realized that #20 is not related to the binary which was fixed in my commit

@timaschew timaschew changed the title handle error, fix #20 and comments of #22 handle error, comments of #22 Dec 7, 2015
@tschaub tschaub changed the title handle error, comments of #22 Make CLI exit with error if publishing fails Dec 7, 2015
@tschaub
Copy link
Owner

tschaub commented Dec 7, 2015

Thanks for this @timaschew.

Minor, but if pull request descriptions include the fixes #X syntax, it lets us control which pull request fixes which issue. By contrast, if commits include the fixes #X syntax, we end up with a lot of potentially confusing noise on issues as people rework commits trying to get to the final solution. This is a bit of a personal preference, I know.

tschaub added a commit that referenced this pull request Dec 7, 2015
@tschaub
Merge pull request #35 from timaschew/patch-1
392de02 
Make CLI exit with error if publishing fails.
@tschaub tschaub merged commit 392de02 into tschaub:master Dec 7, 2015
This was referenced Dec 7, 2015
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timaschew @tschaub