better error handling

[timaschew]

• provide error handling for callback
• provide default error handling if no callback is passed

[tschaub]

Do you really mean to only log here if !err?

[timaschew]

Yes. lol no I mean err != null but this was criticized by the linter, of course I mean !!err

I think if the caller is not interested in handling any successful callback, because it's the last action anyway or so, then he should be notified in the error case.

But you can also omit the logging in the binary here https://github.com/tschaub/gh-pages/blob/master/bin/gh-pages#L35
and do a successful log in this file.

[tschaub]

I'm just confused why you would want to log undefined or other falsy values.

To be clear, did you mean to write this:

if (err) {
  console.log(err);
}

instead of this:

if (!err) {
  console.log(err);
}

?

[timaschew]

Sorry, you're right, I edit my previous answer.
But if (err){} didn't work, the error is falsy, so !!err handles it the right way or err != null

[timaschew]

and err != null was linted with this error: gh-pages/lib/index.js 63:13 error Use ‘===’ to compare with ‘null’ no-eq-null

which is really sad, because null check with != makes sense to check against undefined and null

[timaschew]

haha !! is not allowed too.

So either one of the rules needs to be disabled or the check should be
if (typeof err !== 'undefined' && err !== null) {}

[tschaub]

@timaschew you can just write this:

if (err) {
  // do something
}

This behaves exactly the same as this:

if (!!err) {
  // do something
}

[timaschew]

That's true ^^
I tried this in the morning today, but seems that I was confused a little bit...