Improve publish API #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the module to be used like so: ghpages.deploy(basePath, callback)
|
Any thoughts on this? This is probably the final thing I'd need for the next version to be published to npm. |
|
Looks good to me @markdalgleish. |
tschaub
added a commit
that referenced
this pull request
Jun 29, 2014
Make base path required and options optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has a few changes:
ghpages.publish(basePath, callback)publishfunction is now variadic and I'm not sure it's worth the trouble. Happy to be convinced otherwise :)