When src and dest are the same and one-to-one #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src file (for in place operations like some grunt-contrib-imagemin use cases.
|
Thanks for digging intro this @btholt. This looks promising. Will merge it in when I can give it a closer look. |
|
No problem! Hope it helps! It could probably use a test case too but I'm not terribly versed in testing Grunt plugins. Let me know if can help more. |
|
Whew. That took a while. Apologies. Thanks for the fix @btholt. It looks like we can simplify things a bit after this change. I'll handle that separately. |
tschaub
added a commit
that referenced
this pull request
Oct 21, 2014
Compare to previous run time when src and dest are the same and one-to-one.
This was referenced Oct 21, 2014
|
\o/ Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now works where src and dest files are the same and there's only one src file (for in-place operations like some grunt-contrib-imagemin use cases.)
Aims to resolve issue #40