Fix native re-requires #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosston
force-pushed
the
fix-native-re-requires
branch
from
bd5e6e9
to
d7852e5
Compare
|
Looks like the native module used for testing (I've tried both |
|
Closing because #181 fixes the underlying issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #178. As that issue mentions, native modules cannot be re-required after being deleted from the cache (see nodejs/node#6160).
I've kept the commits separate for now to show the failing test. I'd be happy to squash before (possible) merge.
Honestly, both my test and solution feel a little bit like hacks, but I'm not sure there's another way. Perhaps that's the nature of testing/messing with the require cache? Feedback is very welcome.