Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Windows #3

Merged
merged 5 commits into from
Jan 13, 2014
Merged

Test on Windows #3

merged 5 commits into from
Jan 13, 2014

Conversation

tschaub
Copy link
Owner

@tschaub tschaub commented Jan 13, 2014

Confirm that tests pass on Windows.

The path._makeLong function will return paths like these on Windows:

    \\?\c:\foo\bar

The fs.realpath function walks through Windows paths treating '\\?\c:\' as the base directory, so this is what we store.  The process.cwd and os.tmpdir functions may not return the same case for base directory names, so we normalize to lowercase.
@tschaub
Copy link
Owner Author

tschaub commented Jan 13, 2014

With these changes, 427 passing (none failing) on Windows 7 with Node 0.10 and 0.11. There is one test failure on Windows with Node 0.8 (see #4).

tschaub added a commit that referenced this pull request Jan 13, 2014
Confirm that tests pass on Windows.
@tschaub tschaub merged commit 85bd0ee into master Jan 13, 2014
@tschaub tschaub deleted the win branch January 13, 2014 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant