Mock process.cwd and process.chdir methods #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you get a chance to look at this, @tschaub? Let me know if there are any changes I can make. |
|
This looks very nice @timkendrick. Thanks for the contribution! |
tschaub
added a commit
that referenced
this pull request
Jun 25, 2015
Mock process.cwd and process.chdir methods.
|
Great, thanks! |
|
I've published this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there - thanks for a great library!
The only problem I had with it was that the
process.cwd()andprocess.chdir()methods still act on the real filesystem, rather than the mock filesystem. This pull request means that these methods get mocked along with the filesystem bindings, ensuring thatprocessis kept in sync withfs.A couple of points to note:
Let me know if this is all ok!