Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blurb to readme re: graceful-fs and gulp compat #45

Merged
merged 1 commit into from
Jun 25, 2015

Conversation

psalaets
Copy link
Contributor

@psalaets psalaets commented Jun 4, 2015

Changes:

  1. Added some h3 to split up caveats section
  2. Added note about mock-fs not working with graceful-fs 3.0.0+ and gulp 3.7.0+

As far as I can tell gulp 3.6.x works fine with mock-fs.

  • In gulp 3.7.0 the dep on vinyl-fs changed from ^0.1.3 to ^0.2.0.
  • In vinyl-fs 0.2.1 the dep on graceful-fs changed from ^2.0.1 to ^3.0.0.
  • graceful-fs 3.0.0 is where compatibility broke

Relevant issues: #42, #44

Changes:

1. Added some h3 to split up caveats section
2. Added note about mock-fs not working with graceful-fs 3.0.0+ and gulp 3.7.0+

As far as I can tell gulp 3.6.x works fine with mock-fs:
- In [gulp 3.7.0](gulpjs/gulp@2ae9741#diff-b9cfc7f2cdf78a7f4b91a753d10865a2) the dep on vinyl-fs changed from `^0.1.3` to `^0.2.0`.
- In [vinyl-fs 0.2.1](gulpjs/vinyl-fs@c9b2c07) the dep on graceful-fs changed from `2.0.1` to `3.0.0`.
@tschaub
Copy link
Owner

tschaub commented Jun 25, 2015

Thanks for the additional docs @psalaets.

tschaub added a commit that referenced this pull request Jun 25, 2015
Add blurb to readme re: graceful-fs and gulp compat.
@tschaub tschaub merged commit fe2d5fa into tschaub:master Jun 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants