Add support for node v4.x Closes: #59 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @AlexMeah. I think this is a pragmatic solution. In fact there are differences in the I still would like to make some changes so that it requires less monkey patching to support a new version. But I haven't found the time yet. So I think it is time to get this in and make improvements as people find limitations. |
tschaub
added a commit
that referenced
this pull request
Oct 13, 2015
Add support for node v4.x Fixes: #59
|
Thanks for merging this would it be possible to publish it to npm? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comments in #59 indicate that there are no changes between io.js 3.x and node 4.x, thought a PR might be accepted that uses the logic from io.js 3.x.
All the tests are passing in travis for Node v4.2 in travis.