Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add outlineoffsetX and outlineoffsetY in board #186

Closed
wants to merge 2 commits into from

Conversation

techmannih
Copy link
Contributor

@techmannih techmannih commented Feb 18, 2025

fixes #182
/claim #182

before:
image

after
image

Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
3d-viewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 7:45pm

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you create a separate example, the issue is the new version looks super broken even though it's theoretically a fix

@seveibar
Copy link
Contributor

@techmannih where is the fix? Try it on a board that doesn't have an outline

This is /sabotage because you claimed a fix even though there was no fix, you didn't mention that there wasn't a fix

@techmannih
Copy link
Contributor Author

techmannih commented Feb 18, 2025

@seveibar yeah I will add another example

@techmannih techmannih closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3d preview doesn't properly use <board outlineOffsetX or <board outlineOffsetY
2 participants