Add node-12-esm, node-14-esm and node-16-esm to bases

[orta]

No description provided.

[cspotcode]

Are these to use module: node12 or module: esnext?

[orta]

node12 for 12, esnext for the others I think

[cspotcode]

Does esnext allow dynamic imports in a CommonJS file? Or maybe we're getting nodenext and esnext mixed up?

As far as I know, node12 and nodenext are the only module options that allow mixing sync and async module loading in a CommonJS file:

import foo from 'foo'; // compiled to require()
const promise = import('bar'); // compiled to import()

[orta]

Ah yeah, nodenext!

[boda-sh]

With TypeScript 4.5 and module: es2022 out, would you say this is a good node16-esm config to start with?

{
  "$schema": "https://json.schemastore.org/tsconfig",
  "display": "Node 16 ESM",

  "compilerOptions": {
    "module": "es2022",
    "moduleResolution": "node",
    "target": "es2021",
    "lib": ["es2021"],

    "strict": true,
    "esModuleInterop": true,
    "skipLibCheck": true,
    "forceConsistentCasingInFileNames": true
  }
}

[cspotcode]

@bodazhao Should these node*-esm configs use the forthcoming module: nodenext or module: node12? I thought that was the intent, perhaps @orta knows.

[boda-sh]

that has been delayed, see microsoft/TypeScript#46452

[frank-dspeed]

No sorry it is not delayed it is integrated and there is no save default stay with node as default is fine use node12 (cjs & es2015 modules aka __esModules = true)if you want to depend on import export filds of package.json files and finally use esnext the most complicated one which adds the same as node12 but out of esm context view.

[orta]

Handled by #90 - at least for node 16

[mikemykhaylov]

@orta

node12 for 12, esnext for the others I think

With Typescript 4.7 introducing "module": "node16" and "nodenext", would it make sense to use the "node16" for Node 16 + ESM and derivative configs?

[frank-dspeed]

@mmykhaylov depends on the packages that the project consumes this sets if if moduleResolution is not configured diffrent also the moduleResolution so everything with a package.json and not propper exports fild will fail.

i added a node16 consumer folder as composit project for that case and stick with node as resolve algo for the legacy part my final target is ESNext but you could set it to node16 if you do nodejs only packaging and code.

[evantill]

@orta what's the meaning of label you can do this?

something like pr are welcomes ? or like do it in your tsconfig ?

[cspotcode]

It means PRs are welcome

…

On Mon, Apr 10, 2023, 6:04 AM Eric Vantillard ***@***.***> wrote: @orta <https://github.com/orta> what's the meaning of label you can do this? something like *pr are welcomes* ? or like *do it in your tsconfig* ? — Reply to this email directly, view it on GitHub <#76 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAC35ODZKTKOKQWWORZOF4TXAPLJ7ANCNFSM5FGKT5MQ> . You are receiving this because you commented.Message ID: ***@***.***>

[orta]

Actually, this should be closed - we dont support merging tsconfigs now that they can have array extends - I guess you can use node16 and esm now?