Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inconsistent case for "module" field in node bases #209 #210

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

umairraza96
Copy link
Contributor

This addresses the issue no. #209

@orta
Copy link
Member

orta commented Aug 21, 2023

Thanks!

@orta orta merged commit 5b6eb1d into tsconfig:main Aug 21, 2023
1 check passed
@hyperupcall hyperupcall mentioned this pull request Nov 5, 2023
@bennycode
Copy link

What I find confusing is that all values are lowercase now but the https://json.schemastore.org/tsconfig lists the enums with PascalCase:

{
  "enum": [
    "CommonJS",
    "AMD",
    "System",
    "UMD",
    "ES6",
    "ES2015",
    "ES2020",
    "ESNext",
    "None",
    "ES2022",
    "Node16",
    "NodeNext"
  ]
}

When using the autocompletion from my IDE, it suggests me one of the enums (with Pascal Case). Would it be advisable to actually change these in the schema store?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants