Update @tsconfig/bun to reflect changes on bun docs #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generally I agree (for the same reasons) but I also prefer it being the same as the recommendations (even if I think those recommendations are overkill) - so this PR is fine as-is |
|
Sure. Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
@tsconfig/bunto reflect changes on bun docs.The changes are made recently to remove redundant options and fix inconsistency between docs and the generated
tsconfig.jsonby thebun initcommand.oven-sh/bun#8654, oven-sh/bun#8953
The tsconfig is based on https://bun.sh/docs/typescript#suggested-compileroptions.
I'm not sure we should include the stricter flags (
noUnusedLocals,noUnusedParameters,noPropertyAccessFromIndexSignature) which are disabled by default inbun init, because we can enable them by the combination of@tsconfig/bunand@tsconfig/strictest.ref:
tsconfig-for-init.json