-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop display
field
#258
Drop display
field
#258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open to this being post-processed out when we are going from the file in this repo to the file in the npm package, but not for removing the display tag inside these json files.
Having _display in ensures that each base json file is fully self contained
Use a version that is same version at `deploy-changed-npm-packages.ts`
…et scripts/generate-recommend.ts
…et scripts/generate-recommend.ts
8b53fa8
to
7ca1d5c
Compare
Thank you for your review. I changed code that drop Does it accord that you think? |
bases/recommended.json
Outdated
@@ -1,12 +1,12 @@ | |||
{ | |||
"compilerOptions": { | |||
"target": "es2016", | |||
"target": "ES2015", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"target": "ES2015", | |
"target": "ES2016", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me 👍🏻 |
…et scripts/generate-recommend.ts
Thanks! |
resolve: #180