Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop display field #258

Merged
merged 8 commits into from
Mar 27, 2024
Merged

Drop display field #258

merged 8 commits into from
Mar 27, 2024

Conversation

yinm
Copy link
Contributor

@yinm yinm commented Mar 16, 2024

resolve: #180

Copy link
Member

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to this being post-processed out when we are going from the file in this repo to the file in the npm package, but not for removing the display tag inside these json files.

Having _display in ensures that each base json file is fully self contained

@yinm
Copy link
Contributor Author

yinm commented Mar 25, 2024

Thank you for your review.

I changed code that drop display field when generating npm package.
Most of the codes are unusable, so I removed all commits and rebase latest main branch.

Does it accord that you think?

@yinm yinm requested a review from orta March 25, 2024 13:58
@@ -1,12 +1,12 @@
{
"compilerOptions": {
"target": "es2016",
"target": "ES2015",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"target": "ES2015",
"target": "ES2016",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orta
Copy link
Member

orta commented Mar 25, 2024

Seems reasonable to me 👍🏻

@orta orta merged commit be6b3bb into tsconfig:main Mar 27, 2024
1 check passed
@orta
Copy link
Member

orta commented Mar 27, 2024

Thanks!

@yinm yinm deleted the remove-display-field branch March 27, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What is the display key in tsconfig.json?
2 participants