Capture HTTP headers in results #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Headers are written in wire format. CSV output uses base64 to encode headers. Fixes tsenart#303
golangcibot
reviewed
Feb 7, 2020
lib/attack.go
Outdated
| @@ -392,5 +393,9 @@ func (a *Attacker) hit(tr Targeter, name string) *Result { | |||
| res.Error = r.Status | |||
| } | |||
|
|
|||
| var hdr bytes.Buffer | |||
| r.Header.Write(&hdr) | |||
There was a problem hiding this comment.
Error return value of r.Header.Write is not checked (from errcheck)
tsenart
requested changes
Feb 7, 2020
tsenart
approved these changes
Feb 16, 2020
| @@ -217,6 +254,15 @@ func NewCSVDecoder(r io.Reader) Decoder { | |||
|
|
|||
| r.Method = rec[9] | |||
| r.URL = rec[10] | |||
| if len(rec) > 11 { | |||
There was a problem hiding this comment.
I think if we set FieldsPerRecord = 12, then this is always going to be true, or else an error would be returned by read.
FieldsPerRecord is the number of expected fields per record. If FieldsPerRecord is positive, Read requires each record to have the given number of fields.
There was a problem hiding this comment.
Addressing this in a follow up commit. Thanks for the contribution!
Closed
tsenart
added a commit
that referenced
this pull request
Mar 24, 2020
This commit improves the performance of JSON encoding and decoding of `Results`. Additionally, it fixes a regression introduced in #474 that didn't produce valid JSON for HTTP headers. A test is added that validates the JSON encoding matches the one produced by the `encoding/json`. ``` name old time/op new time/op delta ResultEncodings/json-encode-16 690ns ±12% 297ns ± 0% -56.94% (p=0.000 n=9+9) ResultEncodings/json-decode-16 1.05µs ± 1% 0.03µs ± 1% -97.47% (p=0.000 n=10+8) name old alloc/op new alloc/op delta ResultEncodings/json-encode-16 804B ±87% 0B -100.00% (p=0.000 n=9+10) ResultEncodings/json-decode-16 310B ± 0% 0B -100.00% (p=0.000 n=10+10) name old allocs/op new allocs/op delta ResultEncodings/json-encode-16 4.00 ± 0% 0.00 -100.00% (p=0.000 n=10+10) ResultEncodings/json-decode-16 4.00 ± 0% 0.00 -100.00% (p=0.000 n=10+10) ```
tsenart
added a commit
that referenced
this pull request
Mar 24, 2020
* Add .idea to .gitignore * results: Faster JSON encoding and decoding This commit improves the performance of JSON encoding and decoding of `Results`. Additionally, it fixes a regression introduced in #474 that didn't produce valid JSON for HTTP headers. A test is added that validates the JSON encoding matches the one produced by the `encoding/json`. ``` name old time/op new time/op delta ResultEncodings/json-encode-16 690ns ±12% 297ns ± 0% -56.94% (p=0.000 n=9+9) ResultEncodings/json-decode-16 1.05µs ± 1% 0.03µs ± 1% -97.47% (p=0.000 n=10+8) name old alloc/op new alloc/op delta ResultEncodings/json-encode-16 804B ±87% 0B -100.00% (p=0.000 n=9+10) ResultEncodings/json-decode-16 310B ± 0% 0B -100.00% (p=0.000 n=10+10) name old allocs/op new allocs/op delta ResultEncodings/json-encode-16 4.00 ± 0% 0.00 -100.00% (p=0.000 n=10+10) ResultEncodings/json-decode-16 4.00 ± 0% 0.00 -100.00% (p=0.000 n=10+10) ```
olaiojo
pushed a commit
to olaiojo/vegeta
that referenced
this pull request
Feb 15, 2022
3 tasks
olaiojo
added a commit
to olaiojo/vegeta
that referenced
this pull request
Feb 15, 2022
Update README to follow tsenart#474
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Headers are written in wire format. CSV output uses base64 to encode
headers.
Fixes #303