Should clean the fireworks when ngOnDestroy

[Eric-Guo]

I really want to avoid any but the upstream code not export FireworksInstance

/**
 * @param idOrOptions - the id used for displaying the animation, or the animation configuration if an id is not necessary
 * @param sourceOptions - the animation configuration if an id is provided
 * @returns the loaded instance
 */
export async function fireworks(
    idOrOptions: string | RecursivePartial<IFireworkOptions>,
    sourceOptions?: RecursivePartial<IFireworkOptions>,
): Promise<FireworksInstance | undefined> {

[sweep-nightly]

Apply Sweep Rules to your PR?

• Apply: There should not be large sections of commented out code.
• Apply: All docstrings and comments should be up to date.

[sweep-ai]

Apply Sweep Rules to your PR?

• Apply: There should not be large sections of commented out code.
• Apply: All docstrings and comments should be up to date.

This is an automated message generated by Sweep AI.

[matteobruni]

Please check the review comments, I think the promise should be handled in the constructor instead of in the ngDestroy

[Eric-Guo]

FireworksInstance exported in new version and I using it now.

[matteobruni]

The build is failing, can you please fix it? I cannot merge until it fails

[Eric-Guo]

@matteobruni done and really appreciate your work!

[matteobruni]

Still failing

[Eric-Guo]

Interesting, FireworksInstance exported in already published package, any idea why this error happen?

[matteobruni]

I've checked the files of this PR, you are changing only the component, but the dependencies must be updated as well, since that export came in a newer version of @tsparticles/fireworks.

Please build the project locally before submitting commits.

[matteobruni]

Still failing, please build the project locally before submitting other commits.

pnpm install
pnpm run build

in the root folder.

[Eric-Guo]

Should work, thank you for your patience

[matteobruni]

Everything is fine now, thanks!