Skip to content

Commit

Permalink
Adjustments for ancient DotNetFramework compatibility
Browse files Browse the repository at this point in the history
  • Loading branch information
tspence committed Aug 6, 2024
1 parent 80ff089 commit a302d54
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 8 deletions.
6 changes: 3 additions & 3 deletions CSVFile.nuspec
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<package >
<metadata>
<id>CSVFile</id>
<version>3.1.4</version>
<version>3.2.0</version>
<title>CSVFile</title>
<authors>Ted Spence</authors>
<owners>Ted Spence</owners>
Expand All @@ -15,8 +15,8 @@
<releaseNotes>
August 5, 2024

* Add serialization options for arrays and objects
* Fix bad deploy of 3.1.3
* Fix issue with Windows-style newlines crossing chunks found by @joelverhagen
* Fix issue with endless loops reported by @wvvegt
</releaseNotes>
<readme>docs/README.md</readme>
<copyright>Copyright 2006 - 2024</copyright>
Expand Down
14 changes: 9 additions & 5 deletions tests/ReaderTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -359,13 +359,17 @@ public void TestIssue62()
var outputLines = 0;
var rawText = string.Join(Environment.NewLine, linesToRead);

Check failure on line 360 in tests/ReaderTest.cs

View workflow job for this annotation

GitHub Actions / build-ubuntu

Argument 2: cannot convert from 'System.Collections.Generic.List<string>' to 'string[]'
var rawBytes = Encoding.UTF8.GetBytes(rawText);
using var memoryStream = new MemoryStream(rawBytes);
using var streamReader = new StreamReader(memoryStream);
using var csvReader = new CSVReader(streamReader, config);
using (var memoryStream = new MemoryStream(rawBytes))
{
foreach (var row in csvReader)
using (var streamReader = new StreamReader(memoryStream))
{
outputLines++;
using (var csvReader = new CSVReader(streamReader, config))
{
foreach (var row in csvReader)
{
outputLines++;
}
}
}
}
Assert.AreEqual(desiredLines, outputLines);
Expand Down

0 comments on commit a302d54

Please sign in to comment.