Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete unnecessary parameters #84

Merged
merged 2 commits into from
Jan 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pipelines/trainer.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

class TrainingParams(TypedDict):
epochs: int
batch_size: int
loss_criterion: nn.Module
accuracy_criterion: nn.Module
optimizer: nn.Module
Expand Down
1 change: 0 additions & 1 deletion tests/pipelines/test_experimenter.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ def test_run():
model = TestModel()
training_params: TrainingParams = {
"epochs": 1,
"batch_size": 1,
"loss_criterion": nn.MSELoss(),
"accuracy_criterion": nn.L1Loss(),
"optimizer": Adam(model.parameters(), lr=0.0005),
Expand Down