Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removes setAppEnvFile and add version on request header #6

Merged
merged 2 commits into from
Aug 7, 2017
Merged

removes setAppEnvFile and add version on request header #6

merged 2 commits into from
Aug 7, 2017

Conversation

guilhermebr
Copy link
Member

No description provided.

@cezarsa
Copy link
Member

cezarsa commented Aug 4, 2017 •
edited by guilhermebr
Loading

I did a quick grep and found out that the PHP platform relies on /tmp/app_envs: https://github.com/tsuru/platforms/blob/master/php/utils.py#L32
So I think we shouldn't remove it for now.

@cezarsa
Copy link
Member

cezarsa commented Aug 4, 2017

Also, what do you think about adding a prefix to the Version header? Something like X-Agent-Version maybe?

@guilhermebr
Copy link
Member Author

@cezarsa tsuru/platforms#46 solves the problem

@guilhermebr guilhermebr merged commit b0baa76 into master Aug 7, 2017
@guilhermebr guilhermebr deleted the remove_envfile branch August 7, 2017 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggarnier ggarnier ggarnier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guilhermebr @cezarsa @ggarnier