purger: add extra API request tests for extra_headers

tsuru · Apr 8, 2022 · b7eb3b4 · b7eb3b4
1 parent 7eaeee5
commit b7eb3b4
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 1 deletion.
diff --git a/internal/pkg/rpaas/nginx/manager.go b/internal/pkg/rpaas/nginx/manager.go
@@ -61,7 +61,7 @@ func (m NginxManager) PurgeCache(host, purgePath string, port int32, preservePat
 		status := false
 		headers := map[string]string{"Accept-Encoding": encoding}
 		if len(extraHeaders) > 0 {
-			for header, _ := range extraHeaders {
+			for header := range extraHeaders {
 				headers[header] = extraHeaders.Get(header)
 				status, err = m.purge(host, purgePath, port, preservePath, headers)
 				if err != nil {

diff --git a/internal/purge/cache_test.go b/internal/purge/cache_test.go
@@ -5,6 +5,7 @@ import (
 	"io/ioutil"
 	"net/http"
 	"net/http/httptest"
+	"reflect"
 	"strings"
 	"testing"
 
@@ -55,6 +56,21 @@ func TestCachePurge(t *testing.T) {
 				},
 			},
 		},
+		{
+			name:           "success with extra headers",
+			instance:       "sample-rpaasv2",
+			requestBody:    `{"path":"/index.html","preserve_path":false,"extra_headers":{"X-Header":["value"]}}`,
+			expectedStatus: http.StatusOK,
+			expectedBody:   `{"path":"/index.html","instances_purged":2}`,
+			cacheManager: fakeCacheManager{
+				purgeCacheFunc: func(host, path string, port int32, preservePath bool, extraHeaders http.Header) (bool, error) {
+					if path == "/index.html" && reflect.DeepEqual(extraHeaders["X-Header"], []string{"value"}) {
+						return true, nil
+					}
+					return false, nginxManager.NginxError{Msg: "some nginx error"}
+				},
+			},
+		},
 		{
 			name:           "no cache key found",
 			instance:       "sample-rpaasv2",
@@ -154,6 +170,21 @@ func TestCachePurgeBulk(t *testing.T) {
 				},
 			},
 		},
+		{
+			name:           "success with extra headers",
+			instance:       "sample-rpaasv2",
+			requestBody:    `[{"path":"/index.html","preserve_path":false,"extra_headers":{"X-Header":["value"]}}]`,
+			expectedStatus: http.StatusOK,
+			expectedBody:   `[{"path":"/index.html","instances_purged":2}]`,
+			cacheManager: fakeCacheManager{
+				purgeCacheFunc: func(host, path string, port int32, preservePath bool, extraHeaders http.Header) (bool, error) {
+					if path == "/index.html" && reflect.DeepEqual(extraHeaders["X-Header"], []string{"value"}) {
+						return true, nil
+					}
+					return false, nginxManager.NginxError{Msg: "some nginx error"}
+				},
+			},
+		},
 		{
 			name:           "returns bad request if instance is not sent",
 			instance:       "",