manager: add custom annotations as param on create/update instances #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nettoclaudio
approved these changes
Dec 13, 2022
internal/pkg/rpaas/manager.go
Outdated
| @@ -252,6 +262,43 @@ type CertificateData struct { | |||
| Key string `json:"key"` | |||
| } | |||
|
|
|||
| func getAnnotations(params map[string]interface{}) (annotations map[string]string) { | |||
There was a problem hiding this comment.
There are a bunch of validations here. It'd better returning an error in this function in order to make the client notice what happened.
There was a problem hiding this comment.
You're right. At first glance seems to be a first idea just try to ignore them but it's better return it to client
Co-authored-by: Claudio Netto <nettinhorama@gmail.com>
rpaas/k8s: fix lint
morpheu
force-pushed
the
plan_param_map
branch
from
c1291e4 to
1ee10e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.