Remove redundant replace directives #2703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The replace directives for the packages github.com/ajg/form and github.com/samalba/dockerclient are both redundant. We can require github.com/cezarsa/form directly and bypass the replace. gofmt -w -r '"github.com/ajg/form" -> "github.com/cezarsa/form"' . The second replaced package does not seem to be in use according to `go list -m all`. There is a hidden bonus that `go install github.com/tsuru/tsuru/cmd/tsurud@latest` is now a thing.
mauri870
force-pushed
the
feature/remove-replace
branch
from
b978832
to
aa054e8
Compare
|
Thanks @mauri870 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replace directives for the packages
github.com/ajg/formandgit.luolix.top/samalba/dockerclientare both redundant.We can require github.com/cezarsa/form directly and bypass the replace.
The second replaced package does not seem to be in use according to
go list -m all.There is a hidden bonus that
go install github.com/tsuru/tsuru/cmd/tsurud@latestis now a thing.
For: tsuru/tsuru-client#226