Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter-mode behavior #426

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

SnowCait
Copy link
Contributor

@SnowCait SnowCait commented Aug 5, 2024

Pull Request detail

Related issues or PRs/関連issueやPR

related #425

Fix or Add/Remove in this PR/このプルリクエストでやったこと

  • filter_mode に基づいた reviewdog の exit code を全体の結果として適用

Do not fix or add/remove this PR/このプルリクエストでやらなかったこと

  • なし

Pros and Cons/メリットとデメリット

  • ただしく filter_mode が作用し、さらに終了コード的な問題がない

Test/動作確認

snow-actions/sandbox#7

@tsuyoshicho
Copy link
Owner

確認します。

@tsuyoshicho
Copy link
Owner

https://textlint.github.io/docs/cli.html#exit-code

終了コードの意味をとりちがえてました
なにかしらhitしたら非0はgrepなどでもあるので、もうちょっと確認すべきでしたね...

0,1は正常系で2(今後あるとしたらそれ以上)はエラーなので、その方向で修正します。

@tsuyoshicho tsuyoshicho added the bump:patch Bump up patch version label Aug 7, 2024
@tsuyoshicho tsuyoshicho merged commit c5e0d2f into tsuyoshicho:master Aug 7, 2024
7 checks passed
@SnowCait
Copy link
Contributor Author

SnowCait commented Aug 7, 2024

@tsuyoshicho ( "${textlint_exit_val}" != "0" || "${textlint_exit_val}" != "1" ) だと常に true になってしまうので && に直すとうまく動きそうです。

@tsuyoshicho
Copy link
Owner

tsuyoshicho commented Aug 7, 2024

大ボケ……
すぐ直します……

ご迷惑おかけしました
@SnowCait

tsuyoshicho added a commit that referenced this pull request Aug 7, 2024
@SnowCait SnowCait deleted the fix/filter-mode-behavior branch August 7, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump:patch Bump up patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants