Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

font juggling #15

Merged
merged 2 commits into from
Dec 8, 2023
Merged

font juggling #15

merged 2 commits into from
Dec 8, 2023

Conversation

gularsson
Copy link
Contributor

No description provided.

@gularsson gularsson self-assigned this Dec 7, 2023
@gularsson gularsson mentioned this pull request Dec 7, 2023
Merged
dannelundqvist
dannelundqvist approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@dannelundqvist dannelundqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

I would suggest we add the weights 300, 600 and 800 as well, and expose them as tailwind classes font-light, font-bold and font-extrabold. Those are usually needed as soon as we do more than simple stuff.

@gularsson gularsson merged commit bd6255c into main Dec 8, 2023
1 check passed
@gularsson gularsson deleted the font-juggling branch December 8, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannelundqvist dannelundqvist dannelundqvist approved these changes

Assignees

@gularsson gularsson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gularsson @dannelundqvist