Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨🐛Add support for pasting and fix onFullfill call on backspace on last element #30

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

a-tokyo
Copy link

@a-tokyo a-tokyo commented Jun 6, 2018

Description

Actions

  • added support for pasting by removing max length = 1 on input and spreading the characters to the next fields while taking care not to exceed the limit
  • fixed onFullfill being called when backspacing the last element by checking for the codeLength
  • reduce bundle size significantly by uninstalling lodash and using only the needed parts
  • added .vscode to .gitignore
  • added package-lock.json

Notes

  • VSCode auto prettifies my code according to prettier, if it's inconvenient let me know

@a-tokyo a-tokyo changed the title ✨Add support for pasting 🐛Fix onFullfill call on backspace on last element ✨🐛Add support for pasting and fix onFullfill call on backspace on last element Jun 6, 2018
@a-tokyo
Copy link
Author

a-tokyo commented Aug 17, 2018

@retyui Did the requested changes 💪

@a-tokyo
Copy link
Author

a-tokyo commented Aug 29, 2018

@retyui Awesome job 🚀 , but how was my PR added there? :D

Copy link

@nishantWM nishantWM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Repository owner deleted a comment from a-tokyo May 23, 2019
NiksCode
NiksCode approved these changes Aug 20, 2020
@a-tokyo
Copy link
Author

a-tokyo commented Oct 13, 2020

Handled conflicts

@a-tokyo
Copy link
Author

a-tokyo commented Oct 14, 2020

@NiksCode @lsabbagh @nishantWM Please let me know if there's anything else I need to do 👍

@csokdara-thefoundry-app
Copy link

There is no onCodeChange function defined on line 286

components/ConfirmationCodeInput.js Show resolved Hide resolved
components/ConfirmationCodeInput.js Outdated Show resolved Hide resolved
@a-tokyo
Copy link
Author

a-tokyo commented Feb 1, 2021

@csokdara-thefoundry-app handled

@DeniferSantiago
Copy link

this has not been implemented yet?

@a-tokyo
Copy link
Author

a-tokyo commented Apr 22, 2021

@DeniferSantiago It's been ready for a while, awaiting merge from contributors ✨

@DeniferSantiago
Copy link

Too bad, don't you have a fork?

@a-tokyo
Copy link
Author

a-tokyo commented Apr 22, 2021

@DeniferSantiago Yes and you can use it from github directly. Replace the version number of react-native-confirmation-code-input with https://github.com/A-Tokyo/react-native-confirmation-code-input in your package.json

@DeniferSantiago
Copy link

Thank you

@a-tokyo
Copy link
Author

a-tokyo commented Apr 22, 2021

@DeniferSantiago My pleasure

jasonwiener added a commit to jasonwiener/react-native-confirmation-code-input that referenced this pull request Jan 5, 2022
✨🐛Add support for pasting and fix onFullfill call on backspace on last element ttdung11t2#30 from A-Tokyo (ttdung11t2#30)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants