Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add headers to REST error object #472

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Harrison-M
Copy link

Problem: Twitter provides rate limit information via custom HTTP headers on each request, but, as of commit 8fcea75, the promise interface no longer exposes the full response from Twitter, so this info is no longer available from 4xx or 5xx responses.

Solution: Attach the headers to the error in the same way that the response body and status code are attached. Since this is relevant metadata for managing Twitter requests, it makes sense to me to include this here, and it shouldn't be too much noise. I also considered attaching the full response to the error object, but that felt excessive. I'm open to discussion either way, though. Thanks for all your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant