Portability fixes #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N2kDef defines the requirements from the library side. It needs millis() to get the current uptime, and delay() to be able to delay execution. The header also comes with a set of macros to be able to store constant data in a more efficient way. Most platforms do not have a specific way of handling const data, but AVR8 needs explicit handling to store constant data on flash without copying it to RAM.
…ino this defaults to Stream.
N2kDef defines the requirements from the library side. It needs millis() to get the current uptime, and delay() to be able to delay execution. The header also comes with a set of macros to be able to store constant data in a more efficient way. Most platforms do not have a specific way of handling const data, but AVR8 needs explicit handling to store constant data on flash without copying it to RAM.
…ino this defaults to Stream.
…nto portability-fixes
For Arduinos we can use the F(..) macro which casts the string to a streamable helper class.
Also fix incorrect itoa usage.
Also fix incorrect itoa usage.
…nto portability-fixes
Instead of inventing our own macros, use the AVR macros and functions in code and define them to nothing on non-AVR targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the Arduino dependency, allowing the library to more easily be used on other platforms. This closes #33.