Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(security): Make all applicable GCE operations implement Applicati… #3

Merged
merged 1 commit into from
Nov 14, 2018
Merged

fix(security): Make all applicable GCE operations implement Applicati… #3

merged 1 commit into from
Nov 14, 2018

Conversation

ttomsu
Copy link
Owner

@ttomsu ttomsu commented Nov 14, 2018

…onNameable (by way of ServerGroup[s]Nameable)

cc @jtk54

fix(security): Make all applicable GCE operations implement Applicati…
8068dde 
…onNameable (by way of ServerGroup[s]Nameable)
@ttomsu ttomsu mentioned this pull request Nov 14, 2018
Merged
jtk54
jtk54 approved these changes Nov 14, 2018
View reviewed changes
Copy link

@jtk54 jtk54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

duftler
duftler approved these changes Nov 14, 2018
View reviewed changes
Copy link
Collaborator

@duftler duftler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ttomsu ttomsu merged commit 431f887 into nameable Nov 14, 2018
@ttomsu ttomsu deleted the gce-nameable branch November 14, 2018 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duftler duftler duftler approved these changes

@jtk54 jtk54 jtk54 approved these changes

@ajordens ajordens Awaiting requested review from ajordens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ttomsu @jtk54 @duftler