Use -O0 for coverage info

tttapa · Oct 12, 2019 · 4549007 · 4549007
1 parent b0b0f4d
commit 4549007
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 3 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -45,11 +45,10 @@ set(CMAKE_CPP_FLAGS "${CMAKE_CPP_FLAGS} \
     -Wmissing-include-dirs")
 
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} \
-    -g3 -ggdb -Og -Wall -Wextra -Werror \
+    -g3 -ggdb -O0 -Wall -Wextra -Werror \
     -fdiagnostics-show-option -Wsuggest-override \
     -Wdouble-promotion \
     -Wswitch-default -Wswitch-enum -Wimplicit-fallthrough=3 \
-    -Wstrict-overflow=5 \
     -Wuninitialized \
     -pedantic -pedantic-errors")
 

diff --git a/src/MIDI_Inputs/MIDIInputElement.hpp b/src/MIDI_Inputs/MIDIInputElement.hpp
@@ -30,7 +30,7 @@ class MIDIInputElement {
     virtual void begin() {}
 
     /// Reset the input element to its initial state.
-    virtual void reset() = 0;
+    virtual void reset() {}
 
     /// Update the value of the input element. Used for decaying VU meters etc.
     virtual void update() {}

diff --git a/test/MIDI_Inputs/tests-MCU_VU.cpp b/test/MIDI_Inputs/tests-MCU_VU.cpp
@@ -89,6 +89,36 @@ TEST(MCUVU, decay) {
     Mock::VerifyAndClear(&ArduinoMock::getInstance());
 }
 
+TEST(MCUVU, getFloatValue) {
+    constexpr Channel channel = CHANNEL_3;
+    constexpr uint8_t track = 5;
+    constexpr unsigned int decayTime = 300;
+    MCU::VU vu = {track, channel, decayTime};
+    ChannelMessageMatcher midimsg = {CHANNEL_PRESSURE, channel,
+                                     (track - 1) << 4 | 0xA, 0};
+    EXPECT_CALL(ArduinoMock::getInstance(), millis()).WillOnce(Return(0));
+    MIDIInputElementChannelPressure::updateAllWith(midimsg);
+    EXPECT_FLOAT_EQ(vu.getFloatValue(), 10.0f / 12);
+
+    Mock::VerifyAndClear(&ArduinoMock::getInstance());
+}
+
+TEST(MCUVU, reset) {
+    constexpr Channel channel = CHANNEL_3;
+    constexpr uint8_t track = 5;
+    constexpr unsigned int decayTime = 300;
+    MCU::VU vu = {track, channel, decayTime};
+    ChannelMessageMatcher midimsg = {CHANNEL_PRESSURE, channel,
+                                     (track - 1) << 4 | 0xA, 0};
+    EXPECT_CALL(ArduinoMock::getInstance(), millis()).WillOnce(Return(0));
+    MIDIInputElementChannelPressure::updateAllWith(midimsg);
+    EXPECT_EQ(vu.getValue(), 0xA);
+    vu.reset();
+    EXPECT_EQ(vu.getValue(), 0x0);
+
+    Mock::VerifyAndClear(&ArduinoMock::getInstance());
+}
+
 // -------------------------------------------------------------------------- //
 
 TEST(MCUVUBankable, setValueBankChangeAddress) {