[PR] Implement building bipartite graph, calculate cost values of each edge, assign and make humans #42
Conversation
| } | ||
| return Human(keypoints: keypoints, lines: []) | ||
| } | ||
| } | ||
|
|
||
| func parseAllPartOnMultiHuman(from output: TFLiteFlatArray<Float32>, with threshold: Float?) -> [Human] { |
There was a problem hiding this comment.
I recommend to divide 'parseAllPartOnMultiHuman' to tasks.
example)
func parseAllPartOnMultiHuman() {
...
makePair()
makeEdgesForEachPair()
merge()
makeHumans()
}When you divide 'parseAllPartOnMultiHuman',
you have to make a tasks that have same abstract level.
There was a problem hiding this comment.
This suggestion is really important, but I'll refactoring on next PR soon.
|
|
||
| // return [] | ||
| // 5. Merging | ||
| var tmpHumans: [[(col: Int, row: Int, val: Float32)?]] = [] |
There was a problem hiding this comment.
If you possible, Don't use 'tmp'.
It's looks incomplete code.
There was a problem hiding this comment.
I'll try to change. thx :)
| } | ||
|
|
||
| guard let startingPartVertices = verticesForEachPart[startingPartIndex], | ||
| let endingPartVertices = verticesForEachPart[endingPartIndex] else { fatalError("cannot get verties for assignment") } |
There was a problem hiding this comment.
can 'output.keypoints' return nil?
There was a problem hiding this comment.
@syjdev
No. startingPartVertices and endingPartVertices type's element can be nil. Because startingPartVertices and endingPartVertices are initialized with nil in fixed size.
But it's weird... I'll change startingPartVertices and endingPartVertices to non-nil element array and try to remove the guard statement.
👍
| @@ -61,7 +61,9 @@ class OpenPosePoseEstimator: PoseEstimator { | |||
| } | |||
|
|
|||
| var pairNames: [String]? { | |||
| return nil | |||
| return Output.BodyPart.lines.map { | |||
| return "\($0.from.shortName())-\($0.to.shortName())" | |||
There was a problem hiding this comment.
"($0.from.shortName())-($0.to.shortName())" is always String.
This expression never become Optional.
So, I recommend to use [String] for pairNames's type instead [String?].
There was a problem hiding this comment.
@syjdev
pairNames property is defined on PoseEstimator protocol as get-only.
There are 4 classes confirmed PoseEstimator protocol:
PoseNetPoseEstimatorPEFMCPMPoseEstimatorPEFMHourglassPoseEstimatorOpenPosePoseEstimator
But OpenPosePoseEstimator return non-nil array on pairNames and others return nil, because PoseNetPoseEstimator, PEFMCPMPoseEstimator, and PEFMHourglassPoseEstimator don't support multi pose estimation.
| // sampling | ||
| let numberOfSamples = 10 | ||
| let dx = Float(xDiff) / Float(numberOfSamples) | ||
| let dy = Float(yDiff) / Float(numberOfSamples) |
There was a problem hiding this comment.
are types of xDiff, yDiff Float?
There was a problem hiding this comment.
@syjdev
Oh, that's right. There is no need to cast.
| } | ||
| } | ||
|
|
||
| edges.sort { $0.cost > $1.cost } |
There was a problem hiding this comment.
you sort edges twice. is this alright?
There was a problem hiding this comment.
I think it was my mistake. Thx 👍
…g on post-processing step
…post-process of OpenPose
tucan9389
changed the title
tucan9389
changed the title
tucan9389
changed the title
Related Issues
PR Points
OpenPosePoseEstimator.Output.BodyPart.linescorrectly1. NMS
#38
2. Bipartite Graph
3. Line Integral
ref
ref: wiki
4. Assignment
Sort by cost on a pair and perform assignment process.
In the following pair case, only 2 connections remain from 6 connection candidates.
5. Merging
Reference