Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR] Implement non maximum suppression for multi pose estimation #38

Merged
merged 4 commits into from
Apr 26, 2020
Merged

[PR] Implement non maximum suppression for multi pose estimation #38

merged 4 commits into from
Apr 26, 2020

Conversation

tucan9389
Copy link
Owner

@tucan9389 tucan9389 commented Apr 18, 2020 •
edited
Loading

PR Points

  • Implement to get points from heatmap using NMS(Non-Maximum Suppression) algorithm
  • Add each part button and all button for part selection on StillImageViewController
  • Add threshold slider on StillImageViewController

Non-Maximum Suppression

  1. Iterate all element on a heatmap
  2. For each element, remain only a maximum value on filter size area (current location ± filter size)
  3. Get the remain values after iteration

Reference

@tucan9389 tucan9389 requested a review from syjdev April 18, 2020 00:31
@tucan9389 tucan9389 self-assigned this Apr 18, 2020
@tucan9389 tucan9389 merged commit 1cef6ad into feature/multi-pose Apr 26, 2020
syjdev
syjdev reviewed Apr 28, 2020
View reviewed changes
PoseEstimation-TFLiteSwift/NonMaximumnonSuppression.swift
let filterSize = 3
var lastMaximumColumns: [MaximumPoint?] = (0..<width).map { _ in nil }
var results: [MaximumPoint] = []

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend to use collection's 'reserveCapacity'.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syjdev
Thanks for your meaningful feedback.

This was referenced Apr 30, 2020
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syjdev syjdev syjdev left review comments

Assignees

@tucan9389 tucan9389

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tucan9389 @syjdev