[PR] Support to export overlay view #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…illImageHeatmapViewController
MBKwon
reviewed
May 5, 2020
| let image = view.uiImage(in: rect) | ||
| let imageData = image.jpegData(compressionQuality: 0.95) | ||
| let paths = FileManager.default.urls(for: .documentDirectory, in: .userDomainMask) | ||
| let fileURL = paths[0].appendingPathComponent("pose-heatmap-demo.jpeg") |
There was a problem hiding this comment.
it is better using first than accessing with index. if first element is empty, it will be crashed.
There was a problem hiding this comment.
Ops. I accept your suggestion. Thanks. 👍
syjdev
reviewed
May 5, 2020
| let fileURL = paths[0].appendingPathComponent("pose-linedot-demo.jpeg") | ||
| try? imageData?.write(to: fileURL) | ||
| let vc = UIActivityViewController(activityItems: [fileURL], applicationActivities: nil) | ||
| present(vc, animated: true) |
There was a problem hiding this comment.
I think, export has 2 tasks.
- export Image.
- show UIActivityViewController.
I recommend to make 2 abstract task(exportImage, showUIActivityViewController).
There was a problem hiding this comment.
@syjdev
Thanks for your opinion.
I think the above function has exporting behavior in the app term. So I'll separate the export(_:) function to saving the image step and show UIActivityViewController step. If you have any other comments, reply feel free.
Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cautions
Related Issue
PR Point