-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filtering prop table docs and examples #169
Add filtering prop table docs and examples #169
Conversation
btw once these are acceptable, I would copy to vue, html example. I think this What do you think on actually adding whatever propTables through |
I would like to try to fit all users needs, and also to keep api as simple as possible.
It is useful if |
Hm... I tried copying Yes, only if we can get a docgen correctly...(sad that what I implemented is useless here...) However for the case of HOC and RenderProps pattern, even if we get the docgen properly, still there is no way to show the main component's propTable(Not a wrapper component such as HOC, RenderProp components, but a actual components that are enhanced by them) I think user wants to see the propTable of enhanced component. To make this happen, I think changing the logic of |
Hi, It is a follow up of #163. I added more examples and it usages or behaviours on propTables.
I found that this
propTable
feature is little bit tricky because of howreact-docgen
orprop-types
works.Hopefully this looks fine(please let me know if anything should be changed)