Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing return provokes wrong metrics delivery #47

Closed
eduardogr opened this issue Oct 24, 2019 · 2 comments · Fixed by #48
Closed

Missing return provokes wrong metrics delivery #47

eduardogr opened this issue Oct 24, 2019 · 2 comments · Fixed by #48

Comments

@eduardogr
Copy link
Collaborator

We missed a return statement after the line 156 of the backend/vault.go file:

and this is provoking that we are sending successful login metrics when we shouldn't:

c.logger.Info("login successful, got a new vault token")

@dannyk81
Copy link
Contributor

yes, indeed 😅 @fcgravalos actually caught that last week when we had a sealed Vault.

We'll do a quick PR to fix this, thanks for noticing this too 👍

@eduardogr
Copy link
Collaborator Author

eduardogr commented Oct 24, 2019

i've just created the issue because he told me about that, i'm doing a quick fix, as soon as i upload it i create the PR

fcgravalos added a commit that referenced this issue Oct 25, 2019
…-function

#47 separating scenarios in renewalLoop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants