We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We missed a return statement after the line 156 of the backend/vault.go file:
and this is provoking that we are sending successful login metrics when we shouldn't:
c.logger.Info("login successful, got a new vault token")
The text was updated successfully, but these errors were encountered:
yes, indeed 😅 @fcgravalos actually caught that last week when we had a sealed Vault.
We'll do a quick PR to fix this, thanks for noticing this too 👍
Sorry, something went wrong.
i've just created the issue because he told me about that, i'm doing a quick fix, as soon as i upload it i create the PR
Merge pull request #48 from eduardogr/eduardogr/47/fixing-renewalLoop…
2cce533
…-function #47 separating scenarios in renewalLoop
Successfully merging a pull request may close this issue.
We missed a return statement after the line 156 of the backend/vault.go file:
and this is provoking that we are sending successful login metrics when we shouldn't:
c.logger.Info("login successful, got a new vault token")
The text was updated successfully, but these errors were encountered: