Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement appRole login #29

Merged
merged 10 commits into from
May 22, 2019
Merged

implement appRole login #29

merged 10 commits into from
May 22, 2019

Conversation

fcgravalos
Copy link
Contributor

Fixes #27

  • Implement AppRole auth method. This will make secrets-manager more resilient to network issues or sealing issues.
  • secrets-manager will continue to renew its token, but in case there's a failure to fetch such token it will try login again and get a new one.

cc @rvojcik

@fcgravalos
Copy link
Contributor Author

fcgravalos commented May 19, 2019

CircleCI build failing beacuse (I think) mock switched to go modules, using golang.org/x/tools/packages

golang/mock@79d8603

@fcgravalos
Copy link
Contributor Author

I fixed the above issue, but now hitting this weirdo:

mockgen -package mocks \
	-destination mocks/kubernetes.go \
	-source kubernetes/kubernetes.go \
	-mock_names Client=MockKubernetesClient
2019/05/19 20:56:03 Loading input failed: unsupported version of go: exit status 2: flag provided but not defined: -compiled
usage: list [-e] [-f format] [-json] [build flags] [packages]
Run 'go help list' for details.
Makefile:54: recipe for target 'mocks' failed
make: *** [mocks] Error 1
Exited with code 2

Locally works, though :)

@codecov-io
Copy link

codecov-io commented May 19, 2019

Codecov Report

Merging #29 into master will increase coverage by 0.7%.
The diff coverage is 91.17%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #29     +/-   ##
=========================================
+ Coverage   83.79%   84.49%   +0.7%     
=========================================
  Files          11       11             
  Lines         432      458     +26     
=========================================
+ Hits          362      387     +25     
- Misses         55       56      +1     
  Partials       15       15
Impacted Files Coverage Δ
backend/backend.go 100% <ø> (ø) ⬆️
backend/vault_metrics.go 100% <100%> (ø) ⬆️
backend/vault.go 68.84% <88.46%> (+2.17%) ⬆️
backend/vault_engine.go 87.5% <0%> (+12.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2aa3b6...830c16b. Read the comment docs.

@fcgravalos
Copy link
Contributor Author

Had to update circleci golang version, that fixed it :)

@fcgravalos fcgravalos self-assigned this May 20, 2019
@fcgravalos fcgravalos added the enhancement New feature or request label May 20, 2019
@fcgravalos fcgravalos added this to the v1.0.0 milestone May 20, 2019
Copy link
Contributor

@dannyk81 dannyk81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Just few small comments.

backend/vault.go Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
dannyk81
dannyk81 previously approved these changes May 21, 2019
Copy link
Contributor

@dannyk81 dannyk81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Just few small comments.

@fcgravalos fcgravalos merged commit be4b64e into tuenti:master May 22, 2019
@fcgravalos fcgravalos deleted the I27_vault_approle branch May 22, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation of AppRole Auth
4 participants