-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement appRole login #29
Conversation
CircleCI build failing beacuse (I think) mock switched to go modules, using golang.org/x/tools/packages |
I fixed the above issue, but now hitting this weirdo:
Locally works, though :) |
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
=========================================
+ Coverage 83.79% 84.49% +0.7%
=========================================
Files 11 11
Lines 432 458 +26
=========================================
+ Hits 362 387 +25
- Misses 55 56 +1
Partials 15 15
Continue to review full report at Codecov.
|
Had to update circleci golang version, that fixed it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Just few small comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Just few small comments.
Fixes #27
secrets-manager
will continue to renew its token, but in case there's a failure to fetch such token it will try login again and get a new one.cc @rvojcik