Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.1 #45

Merged
merged 2 commits into from
Oct 4, 2019
Merged

Release 1.0.1 #45

merged 2 commits into from
Oct 4, 2019

Conversation

fcgravalos
Copy link
Contributor

No description provided.

avenging and others added 2 commits October 4, 2019 09:01
@fcgravalos fcgravalos self-assigned this Oct 4, 2019
@fcgravalos fcgravalos requested a review from dannyk81 October 4, 2019 11:33
@codecov-io
Copy link

Codecov Report

Merging #45 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #45      +/-   ##
=======================================
- Coverage   84.25%   84%   -0.26%     
=======================================
  Files           8     8              
  Lines         432   425       -7     
=======================================
- Hits          364   357       -7     
  Misses         51    51              
  Partials       17    17
Impacted Files Coverage Δ
controllers/secretdefinition_controller.go 75.78% <0%> (-1.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee64d0b...1b1238b. Read the comment docs.

@fcgravalos fcgravalos requested a review from eduardogr October 4, 2019 11:41
@eduardogr
Copy link
Collaborator

eduardogr commented Oct 4, 2019

Just a comment, note that if you comment in PR descriptions, resolve #issue-number you close the issue when you merge this. You can use more keywords:

@fcgravalos fcgravalos merged commit 965146b into master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants