-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update comment to reflect productNameWithExtension() and others #823
Update comment to reflect productNameWithExtension() and others #823
Conversation
…her property values might differ from Xcode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing this @mikeger
Co-authored-by: Kas <kwridan@users.noreply.github.com>
@kwridan thanks for the comment, I updated the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Hola 👋, We want to let you know that your pull request has been marked as stale. It seems that there hasn't been any activity or updates on it for a while. If you're still interested in having this pull request merged or reviewed, please provide any necessary updates or address any feedback that may have been given. We would be happy to continue the review process and consider merging it into the However, if this pull request is no longer a priority or if you've decided to take a different approach, please let us know so we can close it accordingly. Thank you for your understanding and contribution. |
Thanks a lot for the contribution here @mikeger 🙏🏼 |
@all-contributors add @mikeger for code |
I've put up a pull request to add @mikeger! 🎉 |
Resolves #820
Short description 📝
Based on my experience using XcodeProj, I found it confusing that the value of
productNameWithExtension()
and others could be different from the value displayed in Xcode.Solution 📦
Based on the discussion on the issue, we agreed to improve the comment on the given methods.
Implementation 👩💻👨💻
I added the comments to the methods that are obviously affected. In case there are other methods, I can update them as well.