Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment to reflect productNameWithExtension() and others #823

Merged

Conversation

mikeger
Copy link
Contributor

@mikeger mikeger commented May 28, 2024

Resolves #820

Short description 📝

Based on my experience using XcodeProj, I found it confusing that the value of productNameWithExtension() and others could be different from the value displayed in Xcode.

Solution 📦

Based on the discussion on the issue, we agreed to improve the comment on the given methods.

Implementation 👩‍💻👨‍💻

I added the comments to the methods that are obviously affected. In case there are other methods, I can update them as well.

@mikeger mikeger changed the title fix(820): Update comment to reflect productNameWithExtension() and others Update comment to reflect productNameWithExtension() and others May 28, 2024
Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this @mikeger

Sources/XcodeProj/Objects/Targets/PBXTarget.swift Outdated Show resolved Hide resolved
Co-authored-by: Kas <kwridan@users.noreply.github.com>
@mikeger
Copy link
Contributor Author

mikeger commented May 30, 2024

@kwridan thanks for the comment, I updated the PR

Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link

Hola 👋,

We want to let you know that your pull request has been marked as stale. It seems that there hasn't been any activity or updates on it for a while.

If you're still interested in having this pull request merged or reviewed, please provide any necessary updates or address any feedback that may have been given. We would be happy to continue the review process and consider merging it into the main branch.

However, if this pull request is no longer a priority or if you've decided to take a different approach, please let us know so we can close it accordingly.

Thank you for your understanding and contribution.

@github-actions github-actions bot added the stale label Jun 30, 2024
@kwridan kwridan removed the stale label Jul 5, 2024
@kwridan kwridan requested a review from pepicrft July 5, 2024 06:57
@pepicrft
Copy link
Contributor

pepicrft commented Jul 8, 2024

Thanks a lot for the contribution here @mikeger 🙏🏼

@pepicrft pepicrft merged commit f3eb906 into tuist:main Jul 8, 2024
5 checks passed
@pepicrft
Copy link
Contributor

pepicrft commented Jul 8, 2024

@all-contributors add @mikeger for code

Copy link
Contributor

@pepicrft

I've put up a pull request to add @mikeger! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect name of the target product returned from productNameWithExtension()
3 participants