Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the connection error test to work with NodeJS 12.x #543

Merged
merged 2 commits into from
Nov 10, 2019
Merged

Fix the connection error test to work with NodeJS 12.x #543

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c9bcc5
Fix the connection error test to work with NodeJS 12.x
ankon Nov 5, 2019
180f879
Merge branch 'master' into pr/support-nodejs-12.x
Nevon Nov 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/network/connection.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,8 @@ describe('Network > Connection', () => {

test('rejects the Promise in case of errors', async () => {
connection.host = invalidHost
await expect(connection.connect()).rejects.toHaveProperty(
'message',
'Connection error: getaddrinfo ENOTFOUND kafkajs.test kafkajs.test:9092'
)
const messagePattern = /Connection error: getaddrinfo ENOTFOUND kafkajs.test/
await expect(connection.connect()).rejects.toThrow(messagePattern)
expect(connection.connected).toEqual(false)
})
})
Expand Down