Clean shutdown #92
Merged
Clean shutdown #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-goodisman
approved these changes
Dec 18, 2024
| // Start one more goroutine for the HTTP server | ||
| httpServer := makeHTTPServer(aggregatedRedisClients, aggregatedMongoSessions, denylist, syncer) | ||
| go func() { | ||
| httpErr := httpServer.ListenAndServe() | ||
| if httpErr != nil { | ||
| if shuttingDown { |
There was a problem hiding this comment.
is this a race condition?
There was a problem hiding this comment.
small deal since the only result is the wrong log message but worth making sure the handlers go off in the right order.
There was a problem hiding this comment.
Yes, but like you mentioned I'm not sure it matters. The risk is that if it's shut down in the middle of an HTTP server error it won't get reported. The handlers seem to work correctly from my testing. We have three options here: 1) leave as-is, 2) include the HTTP error (messier), 3) add locks (more complexity).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oplogtoredis already captured the SIGINT signal, but this adds SIGTERM as well, which is what k8s sends for termination of a pod. This allows for graceful and clean shutdown. Also corrects a panic from the HTTP server exit that was interrupting the clean shutdown process. Tested locally and confirmed shutdown is working as expected.