Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Helios cameras don't accept new settings #167

Closed
dostuffthatmatters opened this issue May 23, 2023 · 2 comments · Fixed by #166
Closed

Some Helios cameras don't accept new settings #167

dostuffthatmatters opened this issue May 23, 2023 · 2 comments · Fixed by #166
Assignees
Labels
high-priority scope:camtracker status:implemented has been implemented in some dev branch

Comments

@dostuffthatmatters
Copy link
Member

Screenshot 2023-05-23 at 13 15 21

Problem: this is blocking measurements
Solution: Only raise assertion errors on exposure setting (the most important) but only warn on the others.

@dostuffthatmatters
Copy link
Member Author

The solution is this: I will only log a warning, when the camera did not accept a particular setting. However, instead of only sending all settings at the initialization, I will now send all settings on every update of the exposure (every 3 minutes). With this, Helios will not block everything else just because the camera communication is not fully working, but will try it again every 3 minutes.

dostuffthatmatters added a commit that referenced this issue May 23, 2023
@patrickjaigner
Copy link
Contributor

This makes sense. A solution could also be a retry functionality, but I agree that a 3-minute cycle should be good enough and makes the code easier.

@dostuffthatmatters dostuffthatmatters added status:implemented has been implemented in some dev branch high-priority and removed status:planned is assigned to a specific milestone labels May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high-priority scope:camtracker status:implemented has been implemented in some dev branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants