-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Core State #190
Labels
status:implemented
has been implemented in some dev branch
Milestone
Comments
dostuffthatmatters
added a commit
that referenced
this issue
Oct 24, 2023
Rename and combine type files for plc and os state
dostuffthatmatters
added a commit
that referenced
this issue
Oct 24, 2023
Rewrite state class that combines the two states
dostuffthatmatters
added a commit
that referenced
this issue
Oct 24, 2023
Add upload property to state
dostuffthatmatters
added a commit
that referenced
this issue
Oct 24, 2023
Add contextmanager to update state partially
dostuffthatmatters
added a commit
that referenced
this issue
Oct 24, 2023
Move types of state to correct locations Add TODOs Update docstrings
dostuffthatmatters
added a commit
that referenced
this issue
Oct 30, 2023
Parse new state using ZOD and connect it to the dashboard
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now, we have two states (the persistent one and the temporary one). It would be way cleaner to just have one state and null everything temporary on the startup of the core.
Additionally, the way how partial updates are done is very complicated. We can use a contextmanager:
The text was updated successfully, but these errors were encountered: