notifications and app icon #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisve
requested changes
Feb 16, 2025
There was a problem hiding this comment.
Very good work! Appreciate it a ton. There are some minor things that should be fixed which you can see in the attached PR review.
Also, in order for the PR to be approved and completed, UI elements must be added and implemented in the event view sheet that let the user actually set and unset the notifications.
app/src/main/java/tumble/app/tumble/data/notifications/NotificationManager.kt
Show resolved
Hide resolved
app/src/main/java/tumble/app/tumble/extensions/models/NetworkResponseEventExtensions.kt
Show resolved
Hide resolved
app/src/main/java/tumble/app/tumble/extensions/models/NetworkResponseScheduleExtensions.kt
Show resolved
Hide resolved
app/src/main/java/tumble/app/tumble/presentation/viewmodels/AccountViewModel.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the notification flow, similar to the ios version #6
Added the app icon aswell #18