-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prependedContainers #51
base: master
Are you sure you want to change the base?
Conversation
c0d4b4e
to
498d228
Compare
498d228
to
b1ab75e
Compare
@byxorna @kirooshu @alex-laties |
@ribbybibby, I agree that workaround is good until there is a proper solution. What I would recommend as a patch here though is to have a flag for prepend all or append all (current behavior). I think having the prependContainers is confusing and most of the time you do not really care if there are some other containers between your "sidecar" container and the main container, they can start just as normal if they do not have the postStart logic. So I would vote here for just having a global flag on the injection config for whether to prepend the containers or append (default) and that should solve your use case, right? |
Thanks for looking at the PR @kirooshu. Yep, that works for me. I'll make the changes. |
This bool modifies the behaviour of the container injection (prepend, append).
@kirooshu I've pushed the suggested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM
🙇 Thanks for the approve @kirooshu. Is this good to be merged? |
Ping - just checking if anyone has had a chance to look at this? @alex-laties @defect |
What and why?
Adds a field which allows sidecars to be prepended to the top of the list of the containers. This allows use of this workaround for delaying an application until the sidecars are ready:
https://medium.com/@marko.luksa/delaying-application-start-until-sidecar-is-ready-2ec2d21a7b74
Issue: #49
Testing Steps
Please provide adequate testing steps (including screenshots if necessary).
Include any test fixtures or sample configurations in your commit.
make test
)Reviewers
Required reviewers:
@byxorna
Request reviews from other people you want to review this PR in the "Reviewers" section on the right.