Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added explanation for Apple Silicon Mac #50

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

kamakiri1192
Copy link

@kamakiri1192 kamakiri1192 commented Sep 21, 2024

Apple Silicon向け対応

Apple Silicon macの環境でdockerコンテナを起動させる場合いくつか手順が必要なためREADMEに追記しました。

変更内容

  • ARM対応のため、platformを linux/amd64 に指定した起動コマンドを追記
  • sampleのenvのままだとホスト(mac)側から疎通できないため、0.0.0.0 でサーバーを立てるよう変更するよう補足説明を追記

Copy link
Owner

@tuna2134 tuna2134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

マークダウンの形式にそって書いてください。

@Googlefan256
Copy link
Collaborator

マークダウンの形式にそって書いてください。

マークダウンとして表示されているのでこれでいいかと

Copy link
Owner

@tuna2134 tuna2134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

前言撤回
LGTMです

@tuna2134 tuna2134 merged commit 5724251 into tuna2134:main Sep 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants