Potential optimization for IdToCurve

tuokri · Aug 13, 2024 · c34d24a · c34d24a
1 parent fdc81e2
commit c34d24a
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/Classes/FCryptoEC_Prime.uc b/Classes/FCryptoEC_Prime.uc
@@ -502,9 +502,14 @@ static final function int RunCode(
     return R;
 }
 
-static final function CurveParams IdToCurve(EFCEllipticCurve Curve)
+// Differs from C version: const out param for performance.
+// TODO: benchmark the actual difference when this has a return value struct.
+static final function IdToCurve(
+    EFCEllipticCurve Curve,
+    const out CurveParams out_CurveParams
+)
 {
-    return default._PP[Curve - FCEC_Secp256r1];
+    out_CurveParams = default._PP[Curve - FCEC_Secp256r1];
 };
 
 static function array<byte> Generator(EFCEllipticCurve Curve, out int Len)