Snapshot perf #222
Merged
Snapshot perf #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mappum
force-pushed
the
snapshot-perf
branch
from
a949522 to
17fc3e8
Compare
mappum
force-pushed
the
snapshot-perf
branch
from
069fa8d to
b583512
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the state snapshots used for historical queries to be backed by RocksDB snapshots (in–memory) rather than checkpoints (on-disk). This should fix performance issues seen on nodes in the wild, as the stacked checkpoints were causing huge amounts of unnecessary compaction work.
Checkpoints are still used for state sync snapshots, and still may have some amount of performance issues which could be improved, but their impact is much smaller since they have a 1000-block interval as opposed to every block.